Can run Windows integration tests under Wine #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
rvl
force-pushed
the
rvl/703/wine-integration-tests
branch
from
469c3fa
to
b35ebce
Compare
|
After boiling down the example to a tiny C program, and ending up enquiring on the wine-devel mailign list, we end up with: piping the wine call through |
KtorZ
force-pushed
the
rvl/703/wine-integration-tests
branch
from
b35ebce
to
aa81f70
Compare
|
My fix apparently did nothing: ... Perhaps it's not in the servant client, but, elsewhere when the network manager is created. |
KtorZ
force-pushed
the
rvl/703/wine-integration-tests
branch
from
aa81f70
to
f0aad4a
Compare
|
Haha! Seems like I found it (see my latest commit). At least, I am not getting any connection error and it seems that Jörmungandr is starting. However, I am running into some weird issues now which seems to be attributed to Jörmungandr inside wine 🤔 ...
|
rvl
force-pushed
the
rvl/703/wine-integration-tests
branch
from
f0aad4a
to
e5c5188
Compare
…pen. Seems like the servant-client does not handle IO / Network exceptions that can occur on Windows correctly. So this is a first work-around that. We may want to move this logic to our Jörmungandr http-client itself to actually properly handle this type of failure on every endpoint.
The other errors are not related to the port being available.
(contains wine tests runner)
rvl
force-pushed
the
rvl/703/wine-integration-tests
branch
from
13fd6fa
to
1193331
Compare
rvl
changed the title
|
Can we review and merge this now, so that we have the isPortOpen bug fix in master? |
Canceled |
|
Oops, I accidentally forced push over a fix. bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 14, 2019
1011: Can run Windows integration tests under Wine r=rvl a=rvl Relates to #703. # Overview - [ ] It's possible to execute `cardano-wallet-jormungandr:test:integration` under Wine. # Comments The tests run on Windows but there is something weird going on with Wine.  To build and run the tests under wine, use: ``` wine $(nix-build release.nix -A x86_64-pc-mingw32.tests.cardano-wallet-jormungandr.integration.x86_64-linux -o integration-windows)/cardano-wallet-jormungandr-2019.11.7/integration.exe ``` 1028: Fix the initial sleep delay in the chain following r=KtorZ a=Anviking # Issue Number #1027 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have changed the initial sleep delay from `0` to `1 s`. # Comments - Minor downside: we sleep for the initial delay on startup. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #703.
Overview
cardano-wallet-jormungandr:test:integrationunder Wine.Comments
The tests run on Windows but there is something weird going on with Wine.
To build and run the tests under wine, use: